feat(Makefile): add fetch tags action #2167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
Wondertan
reviewed
May 5, 2023
renaynay
requested changes
May 5, 2023
renaynay
approved these changes
May 5, 2023
derrandz
previously approved these changes
May 5, 2023
renaynay
requested changes
May 5, 2023
Makefile
Outdated
| @@ -17,7 +17,7 @@ install-hooks: | |||
| .PHONY: init-hooks | |||
|
|
|||
| ## build: Build celestia-node binary. | |||
| build: | |||
| build: fetch-tags | |||
There was a problem hiding this comment.
can you remove fetch-tags from every other target?
There was a problem hiding this comment.
should the build only contain it?
Then it is no sense to have target
Other targets can call git directly if they need to. |
vgonkivs
force-pushed
the
add_fetch_tags_to_makefile
branch
3 times, most recently
from
73f3c2b
to
9a0d544
Compare
|
blocked by celestiaorg/.github#58 |
vgonkivs
force-pushed
the
add_fetch_tags_to_makefile
branch
8 times, most recently
from
9fab3dc
to
5d6caca
Compare
vgonkivs
force-pushed
the
add_fetch_tags_to_makefile
branch
4 times, most recently
from
1a2e501
to
441da7e
Compare
Codecov Report
@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
+ Coverage 55.44% 55.96% +0.52%
==========================================
Files 212 213 +1
Lines 13576 13865 +289
==========================================
+ Hits 7527 7760 +233
- Misses 5286 5332 +46
- Partials 763 773 +10
|
vgonkivs
force-pushed
the
add_fetch_tags_to_makefile
branch
4 times, most recently
from
1635b52
to
a030356
Compare
vgonkivs
force-pushed
the
add_fetch_tags_to_makefile
branch
from
a030356
to
e9d8685
Compare
renaynay
reviewed
May 8, 2023
| @@ -17,6 +17,6 @@ jobs: | |||
| permissions: | |||
| contents: write | |||
| packages: write | |||
| uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_pipeline.yml@v0.1.1 # yamllint disable-line rule:line-length | |||
| uses: celestiaorg/.github/.github/workflows/reusable_dockerfile_pipeline.yml@test_context # yamllint disable-line rule:line-length | |||
There was a problem hiding this comment.
test branch w modified reusable_dockerfile_pipeline
|
N/A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added fetching tags action in order to get the correct semantic version.
Checklist